Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: content/browser/renderer_host/p2p/socket_host_tcp.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/p2p/socket_host_tcp.h
diff --git a/content/browser/renderer_host/p2p/socket_host_tcp.h b/content/browser/renderer_host/p2p/socket_host_tcp.h
index 24aeb97dabdb5920c2a0d9690cc2a59a9d5357a5..e532ae7bb7fdaaea6cc3cda90b4dc9ae63e42143 100644
--- a/content/browser/renderer_host/p2p/socket_host_tcp.h
+++ b/content/browser/renderer_host/p2p/socket_host_tcp.h
@@ -32,21 +32,22 @@ class CONTENT_EXPORT P2PSocketHostTcpBase : public P2PSocketHost {
int socket_id,
P2PSocketType type,
net::URLRequestContextGetter* url_context);
- virtual ~P2PSocketHostTcpBase();
+ ~P2PSocketHostTcpBase() override;
bool InitAccepted(const net::IPEndPoint& remote_address,
net::StreamSocket* socket);
// P2PSocketHost overrides.
- virtual bool Init(const net::IPEndPoint& local_address,
- const P2PHostAndIPEndPoint& remote_address) override;
- virtual void Send(const net::IPEndPoint& to,
- const std::vector<char>& data,
- const rtc::PacketOptions& options,
- uint64 packet_id) override;
- virtual P2PSocketHost* AcceptIncomingTcpConnection(
- const net::IPEndPoint& remote_address, int id) override;
- virtual bool SetOption(P2PSocketOption option, int value) override;
+ bool Init(const net::IPEndPoint& local_address,
+ const P2PHostAndIPEndPoint& remote_address) override;
+ void Send(const net::IPEndPoint& to,
+ const std::vector<char>& data,
+ const rtc::PacketOptions& options,
+ uint64 packet_id) override;
+ P2PSocketHost* AcceptIncomingTcpConnection(
+ const net::IPEndPoint& remote_address,
+ int id) override;
+ bool SetOption(P2PSocketOption option, int value) override;
protected:
// Derived classes will provide the implementation.
@@ -104,13 +105,14 @@ class CONTENT_EXPORT P2PSocketHostTcp : public P2PSocketHostTcpBase {
int socket_id,
P2PSocketType type,
net::URLRequestContextGetter* url_context);
- virtual ~P2PSocketHostTcp();
+ ~P2PSocketHostTcp() override;
protected:
- virtual int ProcessInput(char* input, int input_len) override;
- virtual void DoSend(const net::IPEndPoint& to,
- const std::vector<char>& data,
- const rtc::PacketOptions& options) override;
+ int ProcessInput(char* input, int input_len) override;
+ void DoSend(const net::IPEndPoint& to,
+ const std::vector<char>& data,
+ const rtc::PacketOptions& options) override;
+
private:
DISALLOW_COPY_AND_ASSIGN(P2PSocketHostTcp);
};
@@ -126,13 +128,14 @@ class CONTENT_EXPORT P2PSocketHostStunTcp : public P2PSocketHostTcpBase {
P2PSocketType type,
net::URLRequestContextGetter* url_context);
- virtual ~P2PSocketHostStunTcp();
+ ~P2PSocketHostStunTcp() override;
protected:
- virtual int ProcessInput(char* input, int input_len) override;
- virtual void DoSend(const net::IPEndPoint& to,
- const std::vector<char>& data,
- const rtc::PacketOptions& options) override;
+ int ProcessInput(char* input, int input_len) override;
+ void DoSend(const net::IPEndPoint& to,
+ const std::vector<char>& data,
+ const rtc::PacketOptions& options) override;
+
private:
int GetExpectedPacketSize(const char* data, int len, int* pad_bytes);
« no previous file with comments | « content/browser/renderer_host/p2p/socket_dispatcher_host.h ('k') | content/browser/renderer_host/p2p/socket_host_tcp_server.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698