content/browser/renderer_host/p2p/socket_dispatcher_host.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/p2p/socket_dispatcher_host.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/memory_benchmark_message_filter.h ('k') | content/browser/renderer_host/p2p/socket_host_tcp.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/p2p/socket_dispatcher_host.h

diff --git a/content/browser/renderer_host/p2p/socket_dispatcher_host.h b/content/browser/renderer_host/p2p/socket_dispatcher_host.h

index 692a927821b17b8afc7bfa060008281f94ebc5bb..18b18df22721a047bd76d035057fe2e4f81d816a 100644

--- a/content/browser/renderer_host/p2p/socket_dispatcher_host.h

+++ b/content/browser/renderer_host/p2p/socket_dispatcher_host.h

@@ -39,12 +39,12 @@ class P2PSocketDispatcherHost

net::URLRequestContextGetter* url_context);

// content::BrowserMessageFilter overrides.

- virtual void OnChannelClosing() override;

- virtual void OnDestruct() const override;

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ void OnChannelClosing() override;

+ void OnDestruct() const override;

+ bool OnMessageReceived(const IPC::Message& message) override;

// net::NetworkChangeNotifier::IPAddressObserver interface.

- virtual void OnIPAddressChanged() override;

+ void OnIPAddressChanged() override;

// Starts the RTP packet header dumping. Must be called on the IO thread.

void StartRtpDump(

@@ -56,7 +56,7 @@ class P2PSocketDispatcherHost

void StopRtpDumpOnUIThread(bool incoming, bool outgoing);

protected:

- virtual ~P2PSocketDispatcherHost();

+ ~P2PSocketDispatcherHost() override;

private:

friend struct BrowserThread::DeleteOnThread<BrowserThread::IO>;