content/browser/renderer_host/software_frame_manager.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/software_frame_manager.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/socket_stream_host.cc ('k') | content/browser/renderer_host/software_frame_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/software_frame_manager.h

diff --git a/content/browser/renderer_host/software_frame_manager.h b/content/browser/renderer_host/software_frame_manager.h

index 496a89a4eca1db00aae6e9b57fef838d64419c1b..55729857080b4f96016d4a2a5077e91f286eac0a 100644

--- a/content/browser/renderer_host/software_frame_manager.h

+++ b/content/browser/renderer_host/software_frame_manager.h

@@ -39,7 +39,7 @@ class CONTENT_EXPORT SoftwareFrameManager : public RendererFrameManagerClient {

public:

explicit SoftwareFrameManager(

base::WeakPtr<SoftwareFrameManagerClient> client);

- virtual ~SoftwareFrameManager();

+ ~SoftwareFrameManager() override;

// Swaps to a new frame from shared memory. This frame is guaranteed to

// not be evicted until SwapToNewFrameComplete is called.

@@ -64,7 +64,7 @@ class CONTENT_EXPORT SoftwareFrameManager : public RendererFrameManagerClient {

private:

// Called by SoftwareFrameMemoryManager to demand that the current frame

// be evicted.

- virtual void EvictCurrentFrame() override;

+ void EvictCurrentFrame() override;

base::WeakPtr<SoftwareFrameManagerClient> client_;