content/browser/renderer_host/software_frame_manager_unittest.cc - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/software_frame_manager_unittest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/software_frame_manager.h ('k') | content/browser/renderer_host/text_input_client_mac_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/software_frame_manager_unittest.cc

diff --git a/content/browser/renderer_host/software_frame_manager_unittest.cc b/content/browser/renderer_host/software_frame_manager_unittest.cc

index 8cbd0af47b5ad142405cffe235f161102db497c1..0569f259f1bf9bf91a17d2c65780e2d3156f11b3 100644

--- a/content/browser/renderer_host/software_frame_manager_unittest.cc

+++ b/content/browser/renderer_host/software_frame_manager_unittest.cc

@@ -25,13 +25,11 @@ class FakeSoftwareFrameManagerClient : public SoftwareFrameManagerClient {

HostSharedBitmapManager::current()->ProcessRemoved(

base::GetCurrentProcessHandle());

}

- virtual void SoftwareFrameWasFreed(uint32 output_surface_id,

- unsigned frame_id) override {

+ void SoftwareFrameWasFreed(uint32 output_surface_id,

+ unsigned frame_id) override {

freed_frames_.push_back(std::make_pair(output_surface_id, frame_id));

}

- virtual void ReleaseReferencesToSoftwareFrame() override {

- ++evicted_count_;

- }

+ void ReleaseReferencesToSoftwareFrame() override { ++evicted_count_; }

bool SwapToNewFrame(uint32 output_surface, unsigned frame_id) {

cc::SoftwareFrameData frame;