Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1412)

Unified Diff: content/browser/service_worker/service_worker_url_request_job_unittest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_url_request_job_unittest.cc
diff --git a/content/browser/service_worker/service_worker_url_request_job_unittest.cc b/content/browser/service_worker/service_worker_url_request_job_unittest.cc
index 3126bd0365a367e6fc44247674c8f3ab04067213..3668351d5e623ecdf67c77b261f46db3c2dc92d1 100644
--- a/content/browser/service_worker/service_worker_url_request_job_unittest.cc
+++ b/content/browser/service_worker/service_worker_url_request_job_unittest.cc
@@ -55,9 +55,9 @@ class MockHttpProtocolHandler
base::WeakPtr<storage::BlobStorageContext> blob_storage_context)
: provider_host_(provider_host),
blob_storage_context_(blob_storage_context) {}
- virtual ~MockHttpProtocolHandler() {}
+ ~MockHttpProtocolHandler() override {}
- virtual net::URLRequestJob* MaybeCreateJob(
+ net::URLRequestJob* MaybeCreateJob(
net::URLRequest* request,
net::NetworkDelegate* network_delegate) const override {
ServiceWorkerURLRequestJob* job =
@@ -199,12 +199,12 @@ class BlobResponder : public EmbeddedWorkerTestHelper {
: EmbeddedWorkerTestHelper(mock_render_process_id),
blob_uuid_(blob_uuid),
blob_size_(blob_size) {}
- virtual ~BlobResponder() {}
+ ~BlobResponder() override {}
protected:
- virtual void OnFetchEvent(int embedded_worker_id,
- int request_id,
- const ServiceWorkerFetchRequest& request) override {
+ void OnFetchEvent(int embedded_worker_id,
+ int request_id,
+ const ServiceWorkerFetchRequest& request) override {
SimulateSend(new ServiceWorkerHostMsg_FetchEventFinished(
embedded_worker_id,
request_id,

Powered by Google App Engine
This is Rietveld 408576698