content/browser/browser_plugin/browser_plugin_guest.cc - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.h ('k') | content/browser/browser_plugin/browser_plugin_message_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_guest.cc

diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc

index efb76e0981600735a1f233629aa7b88b6356761c..68876eae405c0cf8ff8536250210100cad15fc34 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.cc

+++ b/content/browser/browser_plugin/browser_plugin_guest.cc

@@ -51,15 +51,14 @@ class BrowserPluginGuest::EmbedderWebContentsObserver

browser_plugin_guest_(guest) {

}

- virtual ~EmbedderWebContentsObserver() {

- }

+ ~EmbedderWebContentsObserver() override {}

// WebContentsObserver implementation.

- virtual void WasShown() override {

+ void WasShown() override {

browser_plugin_guest_->EmbedderVisibilityChanged(true);

}

- virtual void WasHidden() override {

+ void WasHidden() override {

browser_plugin_guest_->EmbedderVisibilityChanged(false);

}