content/browser/browser_plugin/browser_plugin_message_filter.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_message_filter.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/browser/browser_plugin/browser_plugin_popup_menu_helper_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_message_filter.h

diff --git a/content/browser/browser_plugin/browser_plugin_message_filter.h b/content/browser/browser_plugin/browser_plugin_message_filter.h

index 10a3b8b17309dd0ab2ea006be8cb6b1e721f254c..672f6de51b6f03f8a973d4a81e84a77816cf8dab 100644

--- a/content/browser/browser_plugin/browser_plugin_message_filter.h

+++ b/content/browser/browser_plugin/browser_plugin_message_filter.h

@@ -20,17 +20,16 @@ class BrowserPluginMessageFilter : public BrowserMessageFilter {

BrowserPluginMessageFilter(int render_process_id);

// BrowserMessageFilter implementation.

- virtual void OverrideThreadForMessage(

- const IPC::Message& message,

- BrowserThread::ID* thread) override;

- virtual bool OnMessageReceived(const IPC::Message& message) override;

- virtual void OnDestruct() const override;

+ void OverrideThreadForMessage(const IPC::Message& message,

+ BrowserThread::ID* thread) override;

+ bool OnMessageReceived(const IPC::Message& message) override;

+ void OnDestruct() const override;

private:

friend class BrowserThread;

friend class base::DeleteHelper<BrowserPluginMessageFilter>;

- virtual ~BrowserPluginMessageFilter();

+ ~BrowserPluginMessageFilter() override;

void ForwardMessageToGuest(const IPC::Message& message);