content/browser/frame_host/render_frame_host_manager.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/frame_host/render_frame_host_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager.h

diff --git a/content/browser/frame_host/render_frame_host_manager.h b/content/browser/frame_host/render_frame_host_manager.h

index a9d5f444d858c0df32f932e44b28c17ae09ed67a..ff9d7699b4a2d00a6787b49cb085bf8addb7bd2e 100644

--- a/content/browser/frame_host/render_frame_host_manager.h

+++ b/content/browser/frame_host/render_frame_host_manager.h

@@ -187,7 +187,7 @@ class CONTENT_EXPORT RenderFrameHostManager : public NotificationObserver {

RenderViewHostDelegate* render_view_delegate,

RenderWidgetHostDelegate* render_widget_delegate,

Delegate* delegate);

- virtual ~RenderFrameHostManager();

+ ~RenderFrameHostManager() override;

// For arguments, see WebContentsImpl constructor.

void Init(BrowserContext* browser_context,

@@ -326,9 +326,9 @@ class CONTENT_EXPORT RenderFrameHostManager : public NotificationObserver {

InterstitialPageImpl* interstitial_page() const { return interstitial_page_; }

// NotificationObserver implementation.

- virtual void Observe(int type,

- const NotificationSource& source,

- const NotificationDetails& details) override;

+ void Observe(int type,

+ const NotificationSource& source,

+ const NotificationDetails& details) override;

// Returns whether the given RenderFrameHost (or its associated

// RenderViewHost) is on the list of swapped out RenderFrameHosts.