content/browser/frame_host/render_frame_host_manager_browsertest.cc - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager_browsertest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.h ('k') | content/browser/frame_host/render_frame_host_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager_browsertest.cc

diff --git a/content/browser/frame_host/render_frame_host_manager_browsertest.cc b/content/browser/frame_host/render_frame_host_manager_browsertest.cc

index 18b5a68784c3e95a39efbed16264505a175c9dec..38eef8cedd454be76f08f8bd6dd13c13628b58b6 100644

--- a/content/browser/frame_host/render_frame_host_manager_browsertest.cc

+++ b/content/browser/frame_host/render_frame_host_manager_browsertest.cc

@@ -1151,7 +1151,7 @@ class RenderViewHostDestructionObserver : public WebContentsObserver {

public:

explicit RenderViewHostDestructionObserver(WebContents* web_contents)

: WebContentsObserver(web_contents) {}

- virtual ~RenderViewHostDestructionObserver() {}

+ ~RenderViewHostDestructionObserver() override {}

void EnsureRVHGetsDestructed(RenderViewHost* rvh) {

watched_render_view_hosts_.insert(rvh);

}

@@ -1161,7 +1161,7 @@ class RenderViewHostDestructionObserver : public WebContentsObserver {

private:

// WebContentsObserver implementation:

- virtual void RenderViewDeleted(RenderViewHost* rvh) override {

+ void RenderViewDeleted(RenderViewHost* rvh) override {

watched_render_view_hosts_.erase(rvh);

}

@@ -1390,7 +1390,7 @@ class RFHMProcessPerTabTest : public RenderFrameHostManagerTest {

public:

RFHMProcessPerTabTest() {}

- virtual void SetUpCommandLine(CommandLine* command_line) override {

+ void SetUpCommandLine(CommandLine* command_line) override {

command_line->AppendSwitch(switches::kProcessPerTab);

}

};