Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: content/browser/appcache/appcache_disk_cache.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/appcache/appcache_disk_cache.h ('k') | content/browser/appcache/appcache_dispatcher_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/appcache/appcache_disk_cache.cc
diff --git a/content/browser/appcache/appcache_disk_cache.cc b/content/browser/appcache/appcache_disk_cache.cc
index f8486b459db2a42fd6a782bbcbc2ed96eb98b46e..382ed45fed2197ae8be5b861e1f310d18a118694 100644
--- a/content/browser/appcache/appcache_disk_cache.cc
+++ b/content/browser/appcache/appcache_disk_cache.cc
@@ -59,8 +59,11 @@ class AppCacheDiskCache::EntryImpl : public Entry {
}
// Entry implementation.
- virtual int Read(int index, int64 offset, net::IOBuffer* buf, int buf_len,
- const net::CompletionCallback& callback) override {
+ int Read(int index,
+ int64 offset,
+ net::IOBuffer* buf,
+ int buf_len,
+ const net::CompletionCallback& callback) override {
if (offset < 0 || offset > kint32max)
return net::ERR_INVALID_ARGUMENT;
if (!disk_cache_entry_)
@@ -69,8 +72,11 @@ class AppCacheDiskCache::EntryImpl : public Entry {
index, static_cast<int>(offset), buf, buf_len, callback);
}
- virtual int Write(int index, int64 offset, net::IOBuffer* buf, int buf_len,
- const net::CompletionCallback& callback) override {
+ int Write(int index,
+ int64 offset,
+ net::IOBuffer* buf,
+ int buf_len,
+ const net::CompletionCallback& callback) override {
if (offset < 0 || offset > kint32max)
return net::ERR_INVALID_ARGUMENT;
if (!disk_cache_entry_)
@@ -80,11 +86,11 @@ class AppCacheDiskCache::EntryImpl : public Entry {
index, static_cast<int>(offset), buf, buf_len, callback, kTruncate);
}
- virtual int64 GetSize(int index) override {
+ int64 GetSize(int index) override {
return disk_cache_entry_ ? disk_cache_entry_->GetDataSize(index) : 0L;
}
- virtual void Close() override {
+ void Close() override {
if (disk_cache_entry_)
disk_cache_entry_->Close();
delete this;
@@ -97,7 +103,7 @@ class AppCacheDiskCache::EntryImpl : public Entry {
}
private:
- virtual ~EntryImpl() {
+ ~EntryImpl() override {
if (owner_)
owner_->RemoveOpenEntry(this);
}
« no previous file with comments | « content/browser/appcache/appcache_disk_cache.h ('k') | content/browser/appcache/appcache_dispatcher_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698