content/browser/appcache/appcache_disk_cache.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_disk_cache.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/dump_accessibility_tree_browsertest.cc ('k') | content/browser/appcache/appcache_disk_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/appcache/appcache_disk_cache.h

diff --git a/content/browser/appcache/appcache_disk_cache.h b/content/browser/appcache/appcache_disk_cache.h

index 9f5697018a25fab112d10e5d2bb7c457cf7c2472..8995e83cf719db91571925f8437a078cbbcf88a1 100644

--- a/content/browser/appcache/appcache_disk_cache.h

+++ b/content/browser/appcache/appcache_disk_cache.h

@@ -26,7 +26,7 @@ class CONTENT_EXPORT AppCacheDiskCache

: public AppCacheDiskCacheInterface {

public:

AppCacheDiskCache();

- virtual ~AppCacheDiskCache();

+ ~AppCacheDiskCache() override;

// Initializes the object to use disk backed storage.

int InitWithDiskBackend(

@@ -44,12 +44,13 @@ class CONTENT_EXPORT AppCacheDiskCache

void Disable();

bool is_disabled() const { return is_disabled_; }

- virtual int CreateEntry(int64 key, Entry** entry,

- const net::CompletionCallback& callback) override;

- virtual int OpenEntry(int64 key, Entry** entry,

- const net::CompletionCallback& callback) override;

- virtual int DoomEntry(int64 key,

- const net::CompletionCallback& callback) override;

+ int CreateEntry(int64 key,

+ Entry** entry,

+ const net::CompletionCallback& callback) override;

+ int OpenEntry(int64 key,

+ Entry** entry,

+ const net::CompletionCallback& callback) override;

+ int DoomEntry(int64 key, const net::CompletionCallback& callback) override;

private:

class CreateBackendCallbackShim;