content/browser/compositor/reflector_impl.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/reflector_impl.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/compositor/owned_mailbox.h ('k') | content/browser/compositor/software_browser_compositor_output_surface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/reflector_impl.h

diff --git a/content/browser/compositor/reflector_impl.h b/content/browser/compositor/reflector_impl.h

index 6123cb5e5efe6f77ca485486f031e22f04ed82c3..f771fe46c333596efac177ebc7fa35d9e758b9d4 100644

--- a/content/browser/compositor/reflector_impl.h

+++ b/content/browser/compositor/reflector_impl.h

@@ -53,7 +53,7 @@ class ReflectorImpl : public base::SupportsWeakPtr<ReflectorImpl>,

BrowserCompositorOutputSurface* surface);

// ui::Reflector implementation.

- virtual void OnMirroringCompositorResized() override;

+ void OnMirroringCompositorResized() override;

// Called in |BrowserCompositorOutputSurface::SwapBuffers| to copy

// the full screen image to the |texture_id_|. This must be called

@@ -99,7 +99,7 @@ class ReflectorImpl : public base::SupportsWeakPtr<ReflectorImpl>,

gpu::MailboxHolder mailbox_holder;

};

- virtual ~ReflectorImpl();

+ ~ReflectorImpl() override;

void AttachToOutputSurfaceOnImplThread(

const gpu::MailboxHolder& mailbox_holder,