content/browser/compositor/software_browser_compositor_output_surface.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/software_browser_compositor_output_surface.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/compositor/reflector_impl.h ('k') | content/browser/compositor/software_browser_compositor_output_surface_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/software_browser_compositor_output_surface.h

diff --git a/content/browser/compositor/software_browser_compositor_output_surface.h b/content/browser/compositor/software_browser_compositor_output_surface.h

index 33f362d89287dc89e1e02e6b622cf4a639786bd3..1df9b366eddab1e068f3b9a50970863541456739 100644

--- a/content/browser/compositor/software_browser_compositor_output_surface.h

+++ b/content/browser/compositor/software_browser_compositor_output_surface.h

@@ -31,13 +31,13 @@ class CONTENT_EXPORT SoftwareBrowserCompositorOutputSurface

IDMap<BrowserCompositorOutputSurface>* output_surface_map,

const scoped_refptr<ui::CompositorVSyncManager>& vsync_manager);

- virtual ~SoftwareBrowserCompositorOutputSurface();

+ ~SoftwareBrowserCompositorOutputSurface() override;

private:

- virtual void SwapBuffers(cc::CompositorFrame* frame) override;

+ void SwapBuffers(cc::CompositorFrame* frame) override;

#if defined(OS_MACOSX)

- virtual void OnSurfaceDisplayed() override;

+ void OnSurfaceDisplayed() override;

#endif

// On the software path we need to explicitly call the proxy to update the