content/browser/accessibility/browser_accessibility_manager.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_mac.h ('k') | content/browser/accessibility/browser_accessibility_manager_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_manager.h

diff --git a/content/browser/accessibility/browser_accessibility_manager.h b/content/browser/accessibility/browser_accessibility_manager.h

index 754294bef6f27a1de98eeef7fd4e9c2ebbf05706..3760141917042f9547b54bfe1aeee56da87b24f7 100644

--- a/content/browser/accessibility/browser_accessibility_manager.h

+++ b/content/browser/accessibility/browser_accessibility_manager.h

@@ -94,7 +94,7 @@ class CONTENT_EXPORT BrowserAccessibilityManager : public ui::AXTreeDelegate {

BrowserAccessibilityDelegate* delegate,

BrowserAccessibilityFactory* factory = new BrowserAccessibilityFactory());

- virtual ~BrowserAccessibilityManager();

+ ~BrowserAccessibilityManager() override;

void Initialize(const ui::AXTreeUpdate& initial_tree);

@@ -187,12 +187,12 @@ class CONTENT_EXPORT BrowserAccessibilityManager : public ui::AXTreeDelegate {

BrowserAccessibility* PreviousInTreeOrder(BrowserAccessibility* node);

// AXTreeDelegate implementation.

- virtual void OnNodeWillBeDeleted(ui::AXNode* node) override;

- virtual void OnNodeCreated(ui::AXNode* node) override;

- virtual void OnNodeChanged(ui::AXNode* node) override;

- virtual void OnNodeCreationFinished(ui::AXNode* node) override;

- virtual void OnNodeChangeFinished(ui::AXNode* node) override;

- virtual void OnRootChanged(ui::AXNode* new_root) override {}

+ void OnNodeWillBeDeleted(ui::AXNode* node) override;

+ void OnNodeCreated(ui::AXNode* node) override;

+ void OnNodeChanged(ui::AXNode* node) override;

+ void OnNodeCreationFinished(ui::AXNode* node) override;

+ void OnNodeChangeFinished(ui::AXNode* node) override;

+ void OnRootChanged(ui::AXNode* new_root) override {}

BrowserAccessibilityDelegate* delegate() const { return delegate_; }

void set_delegate(BrowserAccessibilityDelegate* delegate) {