content/browser/accessibility/browser_accessibility_manager_mac.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_mac.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager.h ('k') | content/browser/accessibility/browser_accessibility_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_manager_mac.h

diff --git a/content/browser/accessibility/browser_accessibility_manager_mac.h b/content/browser/accessibility/browser_accessibility_manager_mac.h

index 908bdb495ac5af405ba1df6c242339e8ae7b98c7..b754a4b44680170fc0976eb9bd552bd47618a693 100644

--- a/content/browser/accessibility/browser_accessibility_manager_mac.h

+++ b/content/browser/accessibility/browser_accessibility_manager_mac.h

@@ -22,17 +22,17 @@ class CONTENT_EXPORT BrowserAccessibilityManagerMac

static ui::AXTreeUpdate GetEmptyDocument();

- virtual BrowserAccessibility* GetFocus(BrowserAccessibility* root) override;

+ BrowserAccessibility* GetFocus(BrowserAccessibility* root) override;

// Implementation of BrowserAccessibilityManager.

- virtual void NotifyAccessibilityEvent(

- ui::AXEvent event_type, BrowserAccessibility* node) override;

+ void NotifyAccessibilityEvent(ui::AXEvent event_type,

+ BrowserAccessibility* node) override;

NSView* parent_view() { return parent_view_; }

private:

- virtual void OnNodeCreationFinished(ui::AXNode* node) override;

- virtual void OnTreeUpdateFinished() override;

+ void OnNodeCreationFinished(ui::AXNode* node) override;

+ void OnTreeUpdateFinished() override;

// This gives BrowserAccessibilityManager::Create access to the class

// constructor.