content/browser/service_worker/service_worker_registration_handle.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration_handle.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_registration.h ('k') | content/browser/service_worker/service_worker_registration_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration_handle.h

diff --git a/content/browser/service_worker/service_worker_registration_handle.h b/content/browser/service_worker/service_worker_registration_handle.h

index d30a99c19ac7fc0d148ac4fad6e1086771216c51..9439027041b405cd82fbf7cf3c6242d7121d2ccc 100644

--- a/content/browser/service_worker/service_worker_registration_handle.h

+++ b/content/browser/service_worker/service_worker_registration_handle.h

@@ -48,14 +48,12 @@ class ServiceWorkerRegistrationHandle

private:

// ServiceWorkerRegistration::Listener overrides.

- virtual void OnVersionAttributesChanged(

+ void OnVersionAttributesChanged(

ServiceWorkerRegistration* registration,

ChangedVersionAttributesMask changed_mask,

const ServiceWorkerRegistrationInfo& info) override;

- virtual void OnRegistrationFailed(

- ServiceWorkerRegistration* registration) override;

- virtual void OnUpdateFound(

- ServiceWorkerRegistration* registration) override;

+ void OnRegistrationFailed(ServiceWorkerRegistration* registration) override;

+ void OnUpdateFound(ServiceWorkerRegistration* registration) override;

// Sets the corresponding version field to the given version or if the given

// version is NULL, clears the field.