Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1857)

Unified Diff: content/browser/service_worker/service_worker_registration_unittest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_registration_unittest.cc
diff --git a/content/browser/service_worker/service_worker_registration_unittest.cc b/content/browser/service_worker/service_worker_registration_unittest.cc
index 300c4755764dfbe1d03aabcc2e8b5662a3dde0a5..73d383ef533d03cc20e9bf8f9edbb626bdb114f4 100644
--- a/content/browser/service_worker/service_worker_registration_unittest.cc
+++ b/content/browser/service_worker/service_worker_registration_unittest.cc
@@ -51,7 +51,7 @@ class ServiceWorkerRegistrationTest : public testing::Test {
observed_registration_->RemoveListener(this);
}
- virtual void OnVersionAttributesChanged(
+ void OnVersionAttributesChanged(
ServiceWorkerRegistration* registration,
ChangedVersionAttributesMask changed_mask,
const ServiceWorkerRegistrationInfo& info) override {
@@ -60,18 +60,17 @@ class ServiceWorkerRegistrationTest : public testing::Test {
observed_info_ = info;
}
- virtual void OnRegistrationFailed(
+ void OnRegistrationFailed(
ServiceWorkerRegistration* registration) override {
NOTREACHED();
}
- virtual void OnRegistrationFinishedUninstalling(
+ void OnRegistrationFinishedUninstalling(
ServiceWorkerRegistration* registration) override {
NOTREACHED();
}
- virtual void OnUpdateFound(
- ServiceWorkerRegistration* registration) override {
+ void OnUpdateFound(ServiceWorkerRegistration* registration) override {
NOTREACHED();
}

Powered by Google App Engine
This is Rietveld 408576698