content/browser/renderer_host/media/audio_input_device_manager.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/audio_input_device_manager.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/touchscreen_tap_suppression_controller.h ('k') | content/browser/renderer_host/media/audio_input_renderer_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/audio_input_device_manager.h

diff --git a/content/browser/renderer_host/media/audio_input_device_manager.h b/content/browser/renderer_host/media/audio_input_device_manager.h

index b7446032140dde9a8800ed5c99251d5e965cbd4f..a2d4ca4f92c64c755ea65c0d7c820be2acdccd70 100644

--- a/content/browser/renderer_host/media/audio_input_device_manager.h

+++ b/content/browser/renderer_host/media/audio_input_device_manager.h

@@ -45,13 +45,13 @@ class CONTENT_EXPORT AudioInputDeviceManager : public MediaStreamProvider {

const StreamDeviceInfo* GetOpenedDeviceInfoById(int session_id);

// MediaStreamProvider implementation, called on IO thread.

- virtual void Register(MediaStreamProviderListener* listener,

- const scoped_refptr<base::SingleThreadTaskRunner>&

- device_task_runner) override;

- virtual void Unregister() override;

- virtual void EnumerateDevices(MediaStreamType stream_type) override;

- virtual int Open(const StreamDeviceInfo& device) override;

- virtual void Close(int session_id) override;

+ void Register(MediaStreamProviderListener* listener,

+ const scoped_refptr<base::SingleThreadTaskRunner>&

+ device_task_runner) override;

+ void Unregister() override;

+ void EnumerateDevices(MediaStreamType stream_type) override;

+ int Open(const StreamDeviceInfo& device) override;

+ void Close(int session_id) override;

void UseFakeDevice();

bool ShouldUseFakeDevice() const;

@@ -73,7 +73,7 @@ class CONTENT_EXPORT AudioInputDeviceManager : public MediaStreamProvider {

void GetFakeDeviceNames(media::AudioDeviceNames* device_names);

typedef std::vector<StreamDeviceInfo> StreamDeviceList;

- virtual ~AudioInputDeviceManager();

+ ~AudioInputDeviceManager() override;

// Enumerates audio input devices on media stream device thread.

void EnumerateOnDeviceThread(MediaStreamType stream_type);