content/browser/renderer_host/media/audio_input_renderer_host.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/audio_input_renderer_host.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/audio_input_device_manager.h ('k') | content/browser/renderer_host/media/audio_input_sync_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/audio_input_renderer_host.h

diff --git a/content/browser/renderer_host/media/audio_input_renderer_host.h b/content/browser/renderer_host/media/audio_input_renderer_host.h

index 43dd3bb8dff8601dffa6c08aadca00232cf70537..b847bf6d4dcdf9fb44a49fe8ff49a50097f1ec82 100644

--- a/content/browser/renderer_host/media/audio_input_renderer_host.h

+++ b/content/browser/renderer_host/media/audio_input_renderer_host.h

@@ -107,19 +107,19 @@ class CONTENT_EXPORT AudioInputRendererHost

media::UserInputMonitor* user_input_monitor);

// BrowserMessageFilter implementation.

- virtual void OnChannelClosing() override;

- virtual void OnDestruct() const override;

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ void OnChannelClosing() override;

+ void OnDestruct() const override;

+ bool OnMessageReceived(const IPC::Message& message) override;

// AudioInputController::EventHandler implementation.

- virtual void OnCreated(media::AudioInputController* controller) override;

- virtual void OnRecording(media::AudioInputController* controller) override;

- virtual void OnError(media::AudioInputController* controller,

- media::AudioInputController::ErrorCode error_code) override;

- virtual void OnData(media::AudioInputController* controller,

- const media::AudioBus* data) override;

- virtual void OnLog(media::AudioInputController* controller,

- const std::string& message) override;

+ void OnCreated(media::AudioInputController* controller) override;

+ void OnRecording(media::AudioInputController* controller) override;

+ void OnError(media::AudioInputController* controller,

+ media::AudioInputController::ErrorCode error_code) override;

+ void OnData(media::AudioInputController* controller,

+ const media::AudioBus* data) override;

+ void OnLog(media::AudioInputController* controller,

+ const std::string& message) override;

private:

// TODO(henrika): extend test suite (compare AudioRenderHost)

@@ -130,7 +130,7 @@ class CONTENT_EXPORT AudioInputRendererHost

struct AudioEntry;

typedef std::map<int, AudioEntry*> AudioEntryMap;

- virtual ~AudioInputRendererHost();

+ ~AudioInputRendererHost() override;

// Methods called on IO thread ----------------------------------------------