content/browser/service_worker/service_worker_context_request_handler.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_request_handler.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_core.h ('k') | content/browser/service_worker/service_worker_context_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_request_handler.h

diff --git a/content/browser/service_worker/service_worker_context_request_handler.h b/content/browser/service_worker/service_worker_context_request_handler.h

index 5b9d45dadfed926c9e31f155d8154461d5573601..c8af8ed5fd9a858d64499e5822dde3a51d559307 100644

--- a/content/browser/service_worker/service_worker_context_request_handler.h

+++ b/content/browser/service_worker/service_worker_context_request_handler.h

@@ -21,15 +21,15 @@ class CONTENT_EXPORT ServiceWorkerContextRequestHandler

base::WeakPtr<ServiceWorkerProviderHost> provider_host,

base::WeakPtr<storage::BlobStorageContext> blob_storage_context,

ResourceType resource_type);

- virtual ~ServiceWorkerContextRequestHandler();

+ ~ServiceWorkerContextRequestHandler() override;

// Called via custom URLRequestJobFactory.

- virtual net::URLRequestJob* MaybeCreateJob(

+ net::URLRequestJob* MaybeCreateJob(

net::URLRequest* request,

net::NetworkDelegate* network_delegate,

ResourceContext* resource_context) override;

- virtual void GetExtraResponseInfo(

+ void GetExtraResponseInfo(

bool* was_fetched_via_service_worker,

bool* was_fallback_required_by_service_worker,

GURL* original_url_via_service_worker,