content/browser/service_worker/service_worker_context_unittest.cc - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_unittest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_request_handler.h ('k') | content/browser/service_worker/service_worker_context_wrapper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_unittest.cc

diff --git a/content/browser/service_worker/service_worker_context_unittest.cc b/content/browser/service_worker/service_worker_context_unittest.cc

index 43419176daac3ae6bd97063f4a66cb4e808c53c6..f04e575f6d796abb069c3a92ce3c36f1d9b980ef 100644

--- a/content/browser/service_worker/service_worker_context_unittest.cc

+++ b/content/browser/service_worker/service_worker_context_unittest.cc

@@ -77,9 +77,9 @@ class RejectInstallTestHelper : public EmbeddedWorkerTestHelper {

explicit RejectInstallTestHelper(int mock_render_process_id)

: EmbeddedWorkerTestHelper(mock_render_process_id) {}

- virtual void OnInstallEvent(int embedded_worker_id,

- int request_id,

- int active_version_id) override {

+ void OnInstallEvent(int embedded_worker_id,

+ int request_id,

+ int active_version_id) override {

SimulateSend(

new ServiceWorkerHostMsg_InstallEventFinished(

embedded_worker_id, request_id,

@@ -92,8 +92,7 @@ class RejectActivateTestHelper : public EmbeddedWorkerTestHelper {

explicit RejectActivateTestHelper(int mock_render_process_id)

: EmbeddedWorkerTestHelper(mock_render_process_id) {}

- virtual void OnActivateEvent(int embedded_worker_id,

- int request_id) override {

+ void OnActivateEvent(int embedded_worker_id, int request_id) override {

SimulateSend(

new ServiceWorkerHostMsg_ActivateEventFinished(

embedded_worker_id, request_id,