Ensure existence of queried elements.

Ensure existence of queried elements.

Added util.querySelector(), which throws error if the query doesn't find an element.
Using it and assert(), ensure the existence of elements which are queried in initialization process of FileManager.
Some trivial fixes for type-check errors are also included.

BUG=406995
TEST=run browser_tests

Committed: https://crrev.com/a81e67c4da7b516aba7ed8202a51a948521a3cdf
Cr-Commit-Position: refs/heads/master@{#300646}

[fukino, 2014-10-21 10:36:23]

fukino@chromium.org changed reviewers:
+ hirono@chromium.org

[fukino, 2014-10-21 10:36:24]

PTAL the CL? Thank you!

[Dan Beam, 2014-10-21 17:22:59]

https://codereview.chromium.org/667933003/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/common/js/util.js (right):

https://codereview.chromium.org/667933003/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/common/js/util.js:1027: throw new Error('Element
not found by ' + selector);
are you guys not using assert() from ui/webui/resources/js/util.js?  i think
it'd be fine to put this method there as well (we already have
getRequiredElement, maybe queryRequiredElement?)

[fukino, 2014-10-22 05:41:01]

fukino@chromium.org changed reviewers:
+ dbeam@chromium.org

[fukino, 2014-10-22 05:41:01]

https://codereview.chromium.org/667933003/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/common/js/util.js (right):

https://codereview.chromium.org/667933003/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/common/js/util.js:1027: throw new Error('Element
not found by ' + selector);
On 2014/10/21 17:22:59, Dan Beam wrote:
> are you guys not using assert() from ui/webui/resources/js/util.js?  i think
> it'd be fine to put this method there as well (we already have
> getRequiredElement, maybe queryRequiredElement?)

Thanks Dan!
getRequiredElement sounds good. PTAL at ui/webui/resources/js/util.js?
We didn't use assert(), but we're going to utilize those utilities to have the
compiler understand our code.

[Dan Beam, 2014-10-22 05:48:53]

util.js lgtm

[hirono, 2014-10-22 06:14:49]

https://codereview.chromium.org/667933003/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/ui/file_grid.js (right):

https://codereview.chromium.org/667933003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/file_grid.js:35: * @param
{Element} self The grid to decorate.
!Element ?

https://codereview.chromium.org/667933003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/file_grid.js:230: li = /** @type
{FileGrid.Item} */ (li);
!FileGrid.Item ?

https://codereview.chromium.org/667933003/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/ui/file_table.js (right):

https://codereview.chromium.org/667933003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/file_table.js:228: * @param
{Element} self Table to decorate.
!Element ?

https://codereview.chromium.org/667933003/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/ui/location_line.js (right):

https://codereview.chromium.org/667933003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/location_line.js:11: * @param
{Element} breadcrumbs Container element for breadcrumbs.
!Element

https://codereview.chromium.org/667933003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/location_line.js:12: * @param
{Element} volumeIcon Volume icon.
ditto

https://codereview.chromium.org/667933003/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/ui/progress_center_panel.js
(right):

https://codereview.chromium.org/667933003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/progress_center_panel.js:171: *
@param {Element} element DOM Element of the process center panel.
!Element

[fukino, 2014-10-22 06:25:43]

https://codereview.chromium.org/667933003/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/ui/file_grid.js (right):

https://codereview.chromium.org/667933003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/file_grid.js:35: * @param
{Element} self The grid to decorate.
On 2014/10/22 06:14:49, hirono wrote:
> !Element ?

Done.

https://codereview.chromium.org/667933003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/file_grid.js:230: li = /** @type
{FileGrid.Item} */ (li);
On 2014/10/22 06:14:48, hirono wrote:
> !FileGrid.Item ?

Done.

https://codereview.chromium.org/667933003/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/ui/file_table.js (right):

https://codereview.chromium.org/667933003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/file_table.js:228: * @param
{Element} self Table to decorate.
On 2014/10/22 06:14:49, hirono wrote:
> !Element ?

Done.

https://codereview.chromium.org/667933003/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/ui/location_line.js (right):

https://codereview.chromium.org/667933003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/location_line.js:11: * @param
{Element} breadcrumbs Container element for breadcrumbs.
On 2014/10/22 06:14:49, hirono wrote:
> !Element

Done.

https://codereview.chromium.org/667933003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/location_line.js:12: * @param
{Element} volumeIcon Volume icon.
On 2014/10/22 06:14:49, hirono wrote:
> ditto

Done.

https://codereview.chromium.org/667933003/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/ui/progress_center_panel.js
(right):

https://codereview.chromium.org/667933003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/ui/progress_center_panel.js:171: *
@param {Element} element DOM Element of the process center panel.
On 2014/10/22 06:14:49, hirono wrote:
> !Element

Done.

[hirono, 2014-10-22 06:29:31]

lgtm! Thanks!

[fukino, 2014-10-22 06:30:05]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2014-10-22 06:30:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/667933003/40001

[commit-bot: I haz the power, 2014-10-22 07:22:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-22 07:23:53]

Patchset 3 (id:??) landed as
https://crrev.com/a81e67c4da7b516aba7ed8202a51a948521a3cdf
Cr-Commit-Position: refs/heads/master@{#300646}