ui/file_manager/file_manager/foreground/js/ui/directory_tree.js - Issue 667933003: Ensure existence of queried elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

Issue 667933003: Ensure existence of queried elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make some parameters non-nullable. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

diff --git a/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js b/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

index 49b103525fe71ba3a821f930ec3c426eb0ed847a..f316a57cc5e196a062d9053a003b6192202c29e0 100644

--- a/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

+++ b/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

@@ -30,7 +30,7 @@ DirectoryItemTreeBaseMethods.updateSubElementsFromList = function(recursive) {

while (this.entries_[index]) {

var currentEntry = this.entries_[index];

var currentElement = this.items[index];

- var label = util.getEntryLabel(tree.volumeManager_, currentEntry);

+ var label = util.getEntryLabel(tree.volumeManager_, currentEntry) || '';

if (index >= this.items.length) {

var item = new DirectoryItem(label, currentEntry, this, tree);

@@ -532,7 +532,7 @@ VolumeItem.prototype.updateSubDirectories = function(recursive) {

for (var i = 0; i < entries.length; i++) {

var item = new DirectoryItem(

- util.getEntryLabel(this.parentTree_.volumeManager_, entries[i]),

+ util.getEntryLabel(this.parentTree_.volumeManager_, entries[i]) || '',

entries[i], this, this.parentTree_);

this.add(item);

item.updateSubDirectories(false);