Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 667823003: [chromedriver] Accept short git hashes Blink revisions (Closed)

Created:
6 years, 2 months ago by samuong
Modified:
6 years, 2 months ago
Reviewers:
stgao
CC:
chromium-reviews, samuong+watch_chromium.org, stgao
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Accept short git hashes Blink revisions BUG=chromedriver:946 TBR=stgao@chromium.org Committed: https://crrev.com/fe34e8522b6c14a1e73a49ddd8fbe88a4e109cce Cr-Commit-Position: refs/heads/master@{#300425}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M chrome/test/chromedriver/chrome/browser_info.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/test/chromedriver/chrome/browser_info_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
samuong
6 years, 2 months ago (2014-10-20 23:48:11 UTC) #1
samuong
6 years, 2 months ago (2014-10-20 23:48:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667823003/1
6 years, 2 months ago (2014-10-20 23:49:57 UTC) #5
stgao
lgtm
6 years, 2 months ago (2014-10-21 00:10:58 UTC) #6
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-21 01:52:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667823003/1
6 years, 2 months ago (2014-10-21 05:28:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 05:50:19 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 05:53:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe34e8522b6c14a1e73a49ddd8fbe88a4e109cce
Cr-Commit-Position: refs/heads/master@{#300425}

Powered by Google App Engine
This is Rietveld 408576698