chrome/test/chromedriver/chrome/browser_info_unittest.cc - Issue 667823003: [chromedriver] Accept short git hashes Blink revisions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/browser_info_unittest.cc

Issue 667823003: [chromedriver] Accept short git hashes Blink revisions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/chromedriver/chrome/browser_info_unittest.cc

diff --git a/chrome/test/chromedriver/chrome/browser_info_unittest.cc b/chrome/test/chromedriver/chrome/browser_info_unittest.cc

index ed68d01c825177f96c1adb612204913ef12ce005..6d91b77eaa49fbf1282ed4678b4f5d9191cb7712 100644

--- a/chrome/test/chromedriver/chrome/browser_info_unittest.cc

+++ b/chrome/test/chromedriver/chrome/browser_info_unittest.cc

@@ -85,6 +85,10 @@ TEST(IsGitHash, GitHash) {

ASSERT_TRUE(IsGitHash("28f741cfcabffe68a9c12c4e7152569c906bd88f"));

}

+TEST(IsGitHash, ShortGitHash) {

+ ASSERT_TRUE(IsGitHash("1493aa5"));

TEST(IsGitHash, GitHashWithUpperCaseCharacters) {

ASSERT_TRUE(IsGitHash("28F741CFCABFFE68A9C12C4E7152569C906BD88F"));

}

« no previous file with comments | « chrome/test/chromedriver/chrome/browser_info.cc ('k') | no next file » | no next file with comments »