Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 667763003: Landing Recent QUIC Changes. (Closed)

Created:
6 years, 2 months ago by ramant (doing other things)
Modified:
6 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Jana, alyssar, Ian Swett, jokulik, rjshade
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC Changes. Demoting a warning message to DLOG(INFO) due to high frequency. Will follow-up with a different CL to log the actual "unusual, we don't think this should really happen" case at the WARNING level. Changed the level of a warning message to dlog(info) Merge internal change: 78113178 https://codereview.chromium.org/665883003/ Fixes two div by zero bugs in QUIC's BBR pacing code that caused server crashes. Fixes are in the internal source code. Merge internal change: 78017204 https://codereview.chromium.org/670533004/ Simplify QuicUnackedPacketMap to expose AddSentPacket, instead of AddPacket, OnRetransmittedPacket, and SetSent. Merge internal change: 77986449 https://codereview.chromium.org/640853005/ Making a whole host of QUIC framing errors pre-decryption non-fatal. If someone is sending random junk prefixed with a real user's CID it should not disrupt the connection. making the QUIC connection resilliant to injected traffic Merge internal change: 77961885 https://codereview.chromium.org/667573006/ Added helper methods to get/set previous_cached_network_params_. Merging the following internal change: Add varz to track accuracy of QUIC bandwidth predictions. Plan is to use this data to calculate possible impact of using bandwidth predictions, get an idea of how accurate our predictions are. Intended varz output is something like: .../spdy4_over_quic/stk_predicted_bw_accuracy_within_5_mins .../spdy4_over_quic/stk_predicted_bw_accuracy_within_50_mins .../spdy4_over_quic/stk_predicted_bw_accuracy_within_500_mins .../spdy4_over_quic/stk_predicted_bw_accuracy_any_time .../spdy4_over_quic/max_stk_predicted_bw_accuracy_within_5_mins .../spdy4_over_quic/max_stk_predicted_bw_accuracy_within_50_mins .../spdy4_over_quic/max_stk_predicted_bw_accuracy_within_500_mins .../spdy4_over_quic/max_stk_predicted_bw_accuracy_any_time Each of these is a map of 20 buckets, covering 10% chunks of the [0%, 200%] range. For example, a bandwidth estimate from 25 minutes ago, that turns out to be 125% of the observed bandwidth, will result in the stk_predicted_bw_accuracy_within_50_mins_histogram{13} bucket being incremented. Merge internal change: 77877600 https://codereview.chromium.org/666003002/ Fix test which times out when FLAGS_quic_allow_more_open_streams is true. Needed to update test to open additional streams to trigger server close. Internal version of the test does something similar already. Merge internal change: 77868811 https://codereview.chromium.org/661423005/ Restoring tests incorrectly removed in cr/77591875 Merge internal change: 77791119 Commented out headers_stream->HasBufferedData() call to fix flaky HandshakeUnblocksFlowControlBlockedHeadersStream unit test. BUG=423586 https://codereview.chromium.org/662233003/ Replace calls to set.count() with ContainsKey in QUIC. Merge internal change: 77762867 https://codereview.chromium.org/665823004/ Allow QUIC's BBR TCP sender to pace based on min rtt and add an explicit PacingRate() method to SendAlgorithmInterface for BBR. Merge internal change: 77668996 https://codereview.chromium.org/664923003/ Removing QUIC_VERSION_18. This also lets us remove the code for -hard-coded session limits, since those apply to v19 or greater -stats tracking % sessions with no flow control -the bulk of AdjustErrorForVersion since there's no outstanding versions with new errors Removing QUIC_VERSION_18. Not flag protected. Merge internal change: 77603158 https://codereview.chromium.org/663013003/ Change QUIC's pacing granularity from 5ms to 1ms to match the kernel's default granularity. Merge internal change: 77587738 https://codereview.chromium.org/665083004/ R=rch@chromium.org Committed: https://crrev.com/6afc6f432ffd8920f4ea8d131177499469657f74 Cr-Commit-Position: refs/heads/master@{#300402}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -388 lines) Patch
M net/quic/congestion_control/pacing_sender.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/congestion_control/pacing_sender.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M net/quic/congestion_control/pacing_sender_test.cc View 4 chunks +12 lines, -26 lines 0 comments Download
M net/quic/congestion_control/rtt_stats.h View 2 chunks +5 lines, -5 lines 0 comments Download
M net/quic/congestion_control/rtt_stats.cc View 2 chunks +8 lines, -1 line 0 comments Download
M net/quic/congestion_control/rtt_stats_test.cc View 10 chunks +25 lines, -17 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 4 chunks +15 lines, -5 lines 0 comments Download
M net/quic/congestion_control/tcp_loss_algorithm_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/time_loss_algorithm_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_connection.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 7 chunks +15 lines, -6 lines 0 comments Download
M net/quic/quic_connection_test.cc View 3 chunks +4 lines, -24 lines 0 comments Download
M net/quic/quic_crypto_server_stream.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M net/quic/quic_data_stream_test.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M net/quic/quic_fec_group.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_framer_test.cc View 1 chunk +6 lines, -14 lines 0 comments Download
M net/quic/quic_protocol.h View 2 chunks +1 line, -3 lines 0 comments Download
M net/quic/quic_protocol.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M net/quic/quic_protocol_test.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 5 chunks +27 lines, -34 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_server_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_session.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M net/quic/quic_session_test.cc View 12 chunks +37 lines, -76 lines 0 comments Download
M net/quic/quic_unacked_packet_map.h View 3 chunks +21 lines, -19 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 4 chunks +39 lines, -44 lines 0 comments Download
M net/quic/quic_unacked_packet_map_test.cc View 14 chunks +69 lines, -46 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 3 chunks +12 lines, -10 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 2 chunks +5 lines, -11 lines 0 comments Download
M net/tools/quic/quic_server_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
ramant (doing other things)
6 years, 2 months ago (2014-10-20 21:47:00 UTC) #1
Ryan Hamilton
lgtm
6 years, 2 months ago (2014-10-20 22:20:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667763003/1
6 years, 2 months ago (2014-10-20 22:24:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 02:15:30 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 03:11:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6afc6f432ffd8920f4ea8d131177499469657f74
Cr-Commit-Position: refs/heads/master@{#300402}

Powered by Google App Engine
This is Rietveld 408576698