Source/devtools/front_end/network/NetworkItemView.js - Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/network/NetworkItemView.js

Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/network/NetworkItemView.js

diff --git a/Source/devtools/front_end/network/NetworkItemView.js b/Source/devtools/front_end/network/NetworkItemView.js

index 0ea8ba00a459a219e4a1ed98f8401daa05a0ebe5..4f1756b37a8a89cbed37c852df62ffb9e44fc0e7 100644

--- a/Source/devtools/front_end/network/NetworkItemView.js

+++ b/Source/devtools/front_end/network/NetworkItemView.js

@@ -43,7 +43,7 @@ WebInspector.NetworkItemView = function(request)

this.addEventListener(WebInspector.TabbedPane.EventTypes.TabSelected, this._tabSelected, this);

- if (request.type === WebInspector.resourceTypes.WebSocket) {

+ if (request.resourceType() === WebInspector.resourceTypes.WebSocket) {

var frameView = new WebInspector.ResourceWebSocketFrameView(request);

this.appendTab("webSocketFrames", WebInspector.UIString("Frames"), frameView);

} else {

« no previous file with comments | « Source/devtools/front_end/elements/ElementsPanel.js ('k') | Source/devtools/front_end/network/NetworkPanel.js » ('j') | no next file with comments »