Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 667633003: Web Animations: Compositor timeOffset should not be scaled (Closed)

Created:
6 years, 2 months ago by dstockwell
Modified:
6 years, 2 months ago
Reviewers:
Timothy Loh, samli
CC:
dstockwell, darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block
Project:
blink
Visibility:
Public.

Description

Web Animations: Compositor timeOffset should not be scaled This also seems to indicate that it's not yet possible to composite an animation with a negative playback rate and infinite duration. BUG=422432 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183957

Patch Set 1 #

Patch Set 2 : isinf -> std::isinf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
A ManualTests/animation/compositor-change-playback-rate.html View 1 chunk +42 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationPlayer.cpp View 1 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
dstockwell
6 years, 2 months ago (2014-10-20 00:18:25 UTC) #2
samli
lgtm
6 years, 2 months ago (2014-10-20 00:49:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667633003/20001
6 years, 2 months ago (2014-10-20 00:53:39 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-20 00:53:45 UTC) #7
Timothy Loh
On 2014/10/20 00:53:45, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 2 months ago (2014-10-20 00:59:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667633003/20001
6 years, 2 months ago (2014-10-20 01:00:42 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 01:50:37 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183957

Powered by Google App Engine
This is Rietveld 408576698