Improved modulo operation in lithium as well as bailout on -0....

Improved modulo operation in lithium as well as bailout on -0.

TEST=none
BUG=none

Committed: http://code.google.com/p/v8/source/detail?r=7300

[Søren Thygesen Gjesse, 2011-03-21 08:42:03]

LGTM with comments addressed.

http://codereview.chromium.org/6676060/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

http://codereview.chromium.org/6676060/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:900: // Compute the quotient.
Please extend comment to say that the quotient is also rounded to 32-bit integer
value.

http://codereview.chromium.org/6676060/diff/1/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):

http://codereview.chromium.org/6676060/diff/1/src/arm/macro-assembler-arm.h#n...
src/arm/macro-assembler-arm.h:829: void JumpIfNotPowerOfTwoOrZeroAndNeg(Register
reg,
Please add a separate comment for this function.

[Alexandre, 2011-03-21 09:05:02]

Thanks for the review.
The updated patch should be uploaded soon.

Alexandre

http://codereview.chromium.org/6676060/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

http://codereview.chromium.org/6676060/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:900: // Compute the quotient.
On 2011/03/21 08:42:03, Søren Gjesse wrote:
> Please extend comment to say that the quotient is also rounded to 32-bit
integer
> value.

Done.

http://codereview.chromium.org/6676060/diff/1/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):

http://codereview.chromium.org/6676060/diff/1/src/arm/macro-assembler-arm.h#n...
src/arm/macro-assembler-arm.h:829: void JumpIfNotPowerOfTwoOrZeroAndNeg(Register
reg,
On 2011/03/21 08:42:03, Søren Gjesse wrote:
> Please add a separate comment for this function.

Done.

[Søren Thygesen Gjesse, 2011-03-22 10:02:08]

LGTM

Committed: http://code.google.com/p/v8/source/detail?r=7300

Thank you for the patch.