Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 6676060: Improved modulo operation in lithium as well as bailout on -0.... (Closed)

Created:
9 years, 9 months ago by Rodolph Perfetta
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Improved modulo operation in lithium as well as bailout on -0. TEST=none BUG=none Committed: http://code.google.com/p/v8/source/detail?r=7300

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -92 lines) Patch
M src/arm/lithium-arm.h View 1 1 chunk +20 lines, -2 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 1 chunk +10 lines, -14 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 10 chunks +107 lines, -76 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Rodolph Perfetta
9 years, 9 months ago (2011-03-17 12:02:24 UTC) #1
Søren Thygesen Gjesse
LGTM with comments addressed. http://codereview.chromium.org/6676060/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6676060/diff/1/src/arm/lithium-codegen-arm.cc#newcode900 src/arm/lithium-codegen-arm.cc:900: // Compute the quotient. Please ...
9 years, 9 months ago (2011-03-21 08:42:03 UTC) #2
Alexandre
Thanks for the review. The updated patch should be uploaded soon. Alexandre http://codereview.chromium.org/6676060/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc ...
9 years, 9 months ago (2011-03-21 09:05:02 UTC) #3
Rodolph Perfetta
9 years, 9 months ago (2011-03-21 15:17:33 UTC) #4
Søren Thygesen Gjesse
9 years, 9 months ago (2011-03-22 10:02:08 UTC) #5
LGTM

Committed: http://code.google.com/p/v8/source/detail?r=7300

Thank you for the patch.

Powered by Google App Engine
This is Rietveld 408576698