Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 6676022: script to dump RO and RW VPDs into /var/log/vpd-log.conf. (Closed)

Created:
9 years, 9 months ago by Louis
Modified:
9 years, 4 months ago
Reviewers:
Dmitry Polukhin, zel
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

script to dump RO and RW VPDs into /var/log/vpd-log.conf. This work originally is done in src/platform/init/vpd-log.conf. But somehow OOBE OEM customization code needs to read the log file in the begin of OOBE, we extract this function into a standalone script for chromeos_startup to call. More CLs will follow up this change. Change-Id: I107a2a6c44ec6b4dee4de2c1b8b45cca846dd6fe BUG=chromium-os:12355 TEST=Tested on machine. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c2452fc

Patch Set 1 #

Total comments: 2

Patch Set 2 : make file creation atomic #

Patch Set 3 : group commands #

Patch Set 4 : set proper file permission #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
A util/dump_vpd_log View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Louis
9 years, 9 months ago (2011-03-11 07:52:41 UTC) #1
Dmitry Polukhin
http://codereview.chromium.org/6676022/diff/1/util/dump_vpd_log File util/dump_vpd_log (right): http://codereview.chromium.org/6676022/diff/1/util/dump_vpd_log#newcode22 util/dump_vpd_log:22: fi >>$VPD_2_0 What about making file creation atomic? I.e. ...
9 years, 9 months ago (2011-03-11 07:56:51 UTC) #2
Louis
http://codereview.chromium.org/6676022/diff/1/util/dump_vpd_log File util/dump_vpd_log (right): http://codereview.chromium.org/6676022/diff/1/util/dump_vpd_log#newcode22 util/dump_vpd_log:22: fi >>$VPD_2_0 Good point. Please see the new version. ...
9 years, 9 months ago (2011-03-11 08:56:17 UTC) #3
Dmitry Polukhin
LGTM But please check that file moved from /tmp will have proper access rights.
9 years, 9 months ago (2011-03-11 09:54:01 UTC) #4
Louis
Thanks. Added chmod go-stwx $TMP. On 2011/03/11 09:54:01, Dmitry Polukhin wrote: > LGTM > > ...
9 years, 9 months ago (2011-03-11 10:02:39 UTC) #5
Dmitry Polukhin
LGTM
9 years, 9 months ago (2011-03-11 10:17:28 UTC) #6
zel
9 years, 9 months ago (2011-03-14 19:22:45 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld 408576698