util/dump_vpd_log - Issue 6676022: script to dump RO and RW VPDs into /var/log/vpd-log.conf.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: util/dump_vpd_log

Issue 6676022: script to dump RO and RW VPDs into /var/log/vpd-log.conf. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/vpd.git@master

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 #!/bin/sh

	2 #

	3 # Helper function to dump VPD RO/RW content into /var/log/vpd_2.0.txt

	4 #

	5 # Used in:

	6 # + OOBE reads this log file for the default locale setting.

	7 # + chrome://system reads this log file.

	8 #

	9 VPD_2_0="/var/log/vpd_2.0.txt"

	10

	11 if [ "$1" = "--force" ]; then

	12 force=1

	13 else

	14 force=0

	15 fi

	16

	17 # Since we don't change the VPD data too often, only create the log file

	18 # if it does not exist.

	19 if [ ! -f $VPD_2_0 \|\| $force -eq 1 ]; then

	20 vpd -i "RO_VPD" -l \|\| echo "RO VPD execute error."

	21 vpd -i "RW_VPD" -l \|\| echo "RW VPD execute error."

	22 fi >>$VPD_2_0
	Dmitry Polukhin 2011/03/11 07:56:51 What about making file creation atomic? I.e. redir What about making file creation atomic? I.e. redirect stdout to tmpfile and mv it to destination file after that. In this case if file is missing Chrome will be able wait for it. But if the file exists it has full output not a part of it. Louis 2011/03/11 08:56:17 Good point. Please see the new version. On 2011/0 Good point. Please see the new version. On 2011/03/11 07:56:51, Dmitry Polukhin wrote: Show quoted text > What about making file creation atomic? I.e. redirect stdout to tmpfile and mv > it to destination file after that. In this case if file is missing Chrome will > be able wait for it. But if the file exists it has full output not a part of it.
	23

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »