styleguide: Allow C++11 "enum class"

styleguide: Allow C++11 "enum class"

Committed: https://crrev.com/4f2d41011677efe8bae6b1139a49baea5ce15bf3
Cr-Commit-Position: refs/heads/master@{#300291}

[mdempsky, 2014-10-17 20:44:27]

mdempsky@chromium.org changed reviewers:
+ jamesr@chromium.org

[mdempsky, 2014-10-17 20:44:28]

Discussion thread keeps stalling.  Consensus seems to be "enum class" is
preferrable (but not required) because of type-safety and namespace cleanliness,
except for bit-flags usage.  Also, continue with Google C++ style guide
convention (i.e., "kFoo") as no compelling reasons to diverge.

[Peter Kasting, 2014-10-17 20:47:05]

On 2014/10/17 20:44:28, mdempsky wrote:
> Discussion thread keeps stalling.  Consensus seems to be "enum class" is
> preferrable (but not required) because of type-safety and namespace
cleanliness,
> except for bit-flags usage.

I really don't think there's consensus on "preferable except for bit-flags
usage" and I don't think you should include the text "Recommended for new code,
except for enumerating bit-flags".  I think we should say nothing there.

[mdempsky, 2014-10-17 20:49:28]

On 2014/10/17 20:47:05, Peter Kasting wrote:
> I think we should say nothing there.

Done.

[jamesr, 2014-10-17 23:10:07]

https://codereview.chromium.org/667483003/diff/20001/styleguide/c++/c++11.html
File styleguide/c++/c++11.html (right):

https://codereview.chromium.org/667483003/diff/20001/styleguide/c++/c++11.htm...
styleguide/c++/c++11.html:94: </tr>
we should explicitly call out that enum classes are still enums and follow enum
naming rules (which means SHOUTY_CASE in the current style guide)

[mdempsky, 2014-10-17 23:29:48]

On 2014/10/17 23:10:07, jamesr wrote:
> we should explicitly call out that enum classes are still enums and follow
enum
> naming rules (which means SHOUTY_CASE in the current style guide)

Done.

[jamesr, 2014-10-20 17:05:52]

The CQ bit was checked by jamesr@chromium.org

[jamesr, 2014-10-20 17:05:53]

lgtm

[commit-bot: I haz the power, 2014-10-20 17:06:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/667483003/40001

[commit-bot: I haz the power, 2014-10-20 17:31:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-20 17:32:51]

Patchset 3 (id:??) landed as
https://crrev.com/4f2d41011677efe8bae6b1139a49baea5ce15bf3
Cr-Commit-Position: refs/heads/master@{#300291}