Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: styleguide/c++/c++11.html

Issue 667483003: styleguide: Allow C++11 "enum class" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Remind readers about Chromium's divergance from Google C++ style Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: styleguide/c++/c++11.html
diff --git a/styleguide/c++/c++11.html b/styleguide/c++/c++11.html
index d579de0fe927feacebddbce32bf0113fae8be65e..1cbe001bd0179e04b0a4d008d79ac83bb3e071fa 100644
--- a/styleguide/c++/c++11.html
+++ b/styleguide/c++/c++11.html
@@ -84,6 +84,18 @@ Style Guide on <code>auto</code></a>. <a href="https://groups.google.com/a/chrom
</tr>
<tr>
+<td>Enumerated Type Classes</td>
+<td><code>enum class <i>classname</i></code></td>
+<td>Provide enums as full classes, with no implicit
+conversion to booleans or integers</td>
+<td><a href="http://stackoverflow.com/questions/6936030/do-we-really-need-enum-class-in-c11">
+enum-class</a></td>
+<td>Enum classes are still enums and follow enum naming rules
+(which means SHOUTY_CASE in the <a href="http://www.chromium.org/developers/coding-style#Naming">current style guide</a>).
+<a href="https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/Q5WmkAImanc">Discussion thread</a></td>
+</tr>
+
+<tr>
<td>Final Specifier</td>
<td><code>final</code></td>
<td> Indicates that a class or function is final and cannot be overridden</td>
@@ -334,16 +346,6 @@ Introduction to the C++11 feature: delegating constructors</a></td>
</tr>
<tr>
-<td>Enumerated Type Classes</td>
-<td><code>enum class <i>classname</i></code></td>
-<td>Provide enums as full classes, with no implicit
-conversion to booleans or integers</td>
-<td><a href="http://stackoverflow.com/questions/6936030/do-we-really-need-enum-class-in-c11">
-enum-class</a></td>
-<td><a href="https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/Q5WmkAImanc">Discussion thread</a></td>
-</tr>
-
-<tr>
<td>Exception Features</td>
<td><code>noexcept</code>, <code>exception_ptr</code>,
<code>current_exception()</code>, <code>rethrow_exception</code>,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698