Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 667453003: First stage of launch for embedded options pages. With this patch, extensions (Closed)

Created:
6 years, 2 months ago by not at google - send to devlin
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

First stage of launch for embedded options pages. With this patch, extensions are allowed to opt-in to having embedded options pages and/or chrome style. The flag --enable-embedded-extension-options makes the default for embedding options pages true unless extensions opt-out. This is still useful for development. BUG=414920 R=rockot@chromium.org Committed: https://crrev.com/9807701d4c6789b9df38a9a33ca28ca4de2861c5 Cr-Commit-Position: refs/heads/master@{#300190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -42 lines) Patch
M chrome/browser/extensions/extension_webui_apitest.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc View 1 chunk +25 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_apitest.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_guest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M extensions/common/manifest_handlers/options_page_info.cc View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
not at google - send to devlin
6 years, 2 months ago (2014-10-17 17:29:03 UTC) #1
Ken Rockot(use gerrit already)
lgtm
6 years, 2 months ago (2014-10-17 18:08:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667453003/1
6 years, 2 months ago (2014-10-17 18:10:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-18 00:50:12 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-18 00:51:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9807701d4c6789b9df38a9a33ca28ca4de2861c5
Cr-Commit-Position: refs/heads/master@{#300190}

Powered by Google App Engine
This is Rietveld 408576698