First stage of launch for embedded options pages. With this patch, extensions

extensions/common/manifest_handlers/options_page_info.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/manifest_handlers/options_page_info.h"
 
 #include "base/files/file_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/utf_string_conversions.h"
 #include "extensions/common/api/extensions_manifest_types.h"
@@ skipping 93 matching lines @@
   return info && info->open_in_tab_;
 }
 
 scoped_ptr<OptionsPageInfo> OptionsPageInfo::Create(
     Extension* extension,
     const base::Value* options_ui_value,
     const std::string& options_page_string,
     std::vector<InstallWarning>* install_warnings,
     base::string16* error) {
   GURL options_page;
+  // Chrome styling is always opt-in.
   bool chrome_style = false;
+  // Extensions can opt in or out to opening in a tab, and users can choose via
+  // the --embedded-extension-options flag which should be the default.
   bool open_in_tab = !FeatureSwitch::embedded_extension_options()->IsEnabled();
 
   // Parse the options_ui object.
-  if (options_ui_value &&
-      FeatureSwitch::embedded_extension_options()->IsEnabled()) {
+  if (options_ui_value) {
     base::string16 options_ui_error;
 
     scoped_ptr<OptionsUI> options_ui =
         OptionsUI::FromValue(*options_ui_value, &options_ui_error);
     if (!options_ui_error.empty()) {
       // OptionsUI::FromValue populates |error| both when there are
       // errors (in which case |options_ui| will be NULL) and warnings
       // (in which case |options_ui| will be valid). Either way, show it
       // as an install warning.
       install_warnings->push_back(
           InstallWarning(base::UTF16ToASCII(options_ui_error)));
     }
 
     if (options_ui) {
       base::string16 options_parse_error;
       if (!ParseOptionsUrl(extension,
                            options_ui->page,
                            keys::kOptionsUI,
                            &options_parse_error,
                            &options_page)) {
         install_warnings->push_back(
             InstallWarning(base::UTF16ToASCII(options_parse_error)));
       }
-      chrome_style =
-          options_ui->chrome_style.get() && *options_ui->chrome_style;
-      open_in_tab = options_ui->open_in_tab.get() && *options_ui->open_in_tab;
+      if (options_ui->chrome_style.get())
+        chrome_style = *options_ui->chrome_style;
+      if (options_ui->open_in_tab.get())
+        open_in_tab = *options_ui->open_in_tab;
     }
   }
 
   // Parse the legacy options_page entry if there was no entry for
   // options_ui.page.
   if (!options_page_string.empty() && !options_page.is_valid()) {
     if (!ParseOptionsUrl(extension,
                          options_page_string,
                          keys::kOptionsPage,
                          error,
@@ skipping 61 matching lines @@
   }
   return true;
 }
 
 const std::vector<std::string> OptionsPageManifestHandler::Keys() const {
   static const char* keys[] = {keys::kOptionsPage, keys::kOptionsUI};
   return std::vector<std::string>(keys, keys + arraysize(keys));
 }
 
 }  // namespace extensions