Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 667433003: Fix a crash when cameraInfo is NULL (Closed)

Created:
6 years, 2 months ago by qinmin
Modified:
6 years, 2 months ago
Reviewers:
mcasas
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix a crash when cameraInfo is NULL It is possible that cameraInfo returns NULL. However, the NULL case is not well handled and it will cause crashes. This change also removed the unncessary JNI call to convert an int to string BUG=424775 Committed: https://crrev.com/f3c57f9b4bb6c0e899a80737244ba1783b6691d2 Cr-Commit-Position: refs/heads/master@{#300578}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M media/base/android/java/src/org/chromium/media/VideoCaptureAndroid.java View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/VideoCaptureFactory.java View 1 chunk +0 lines, -5 lines 0 comments Download
M media/video/capture/android/video_capture_device_factory_android.cc View 1 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
qinmin
PTAL
6 years, 2 months ago (2014-10-17 22:54:58 UTC) #2
mcasas
LGTM with a nit. https://codereview.chromium.org/667433003/diff/1/media/video/capture/android/video_capture_device_factory_android.cc File media/video/capture/android/video_capture_device_factory_android.cc (right): https://codereview.chromium.org/667433003/diff/1/media/video/capture/android/video_capture_device_factory_android.cc#newcode75 media/video/capture/android/video_capture_device_factory_android.cc:75: base::android::ConvertJavaStringToUTF8(device_name), device_id); nit: I would ...
6 years, 2 months ago (2014-10-20 11:33:42 UTC) #3
qinmin
https://codereview.chromium.org/667433003/diff/1/media/video/capture/android/video_capture_device_factory_android.cc File media/video/capture/android/video_capture_device_factory_android.cc (right): https://codereview.chromium.org/667433003/diff/1/media/video/capture/android/video_capture_device_factory_android.cc#newcode75 media/video/capture/android/video_capture_device_factory_android.cc:75: base::android::ConvertJavaStringToUTF8(device_name), device_id); On 2014/10/20 11:33:42, mcasas wrote: > nit: ...
6 years, 2 months ago (2014-10-20 17:46:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667433003/20001
6 years, 2 months ago (2014-10-20 17:48:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/18686)
6 years, 2 months ago (2014-10-20 17:56:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667433003/20001
6 years, 2 months ago (2014-10-21 19:03:51 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/19029)
6 years, 2 months ago (2014-10-21 19:12:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667433003/20001
6 years, 2 months ago (2014-10-22 00:05:19 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-22 00:12:03 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 00:13:14 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f3c57f9b4bb6c0e899a80737244ba1783b6691d2
Cr-Commit-Position: refs/heads/master@{#300578}

Powered by Google App Engine
This is Rietveld 408576698