Fix a crash when cameraInfo is NULL

media/video/capture/android/video_capture_device_factory_android.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/video/capture/android/video_capture_device_factory_android.h"
 
 #include "base/android/jni_string.h"
 #include "base/android/scoped_java_ref.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
@@ skipping 47 matching lines @@
 
   JNIEnv* env = AttachCurrentThread();
 
   int num_cameras = Java_VideoCaptureFactory_getNumberOfCameras(
       env, base::android::GetApplicationContext());
   DVLOG(1) << "VideoCaptureDevice::GetDeviceNames: num_cameras=" << num_cameras;
   if (num_cameras <= 0)
     return;
 
   for (int camera_id = num_cameras - 1; camera_id >= 0; --camera_id) {
+    base::android::ScopedJavaLocalRef<jstring> device_name =
+        Java_VideoCaptureFactory_getDeviceName(env, camera_id);
+    if (device_name.obj() == NULL)
+      continue;
+    std::string device_id = base::IntToString(camera_id);
+
     VideoCaptureDevice::Name name(
-        base::android::ConvertJavaStringToUTF8(
-            Java_VideoCaptureFactory_getDeviceName(env, camera_id)),
-        base::android::ConvertJavaStringToUTF8(
-            Java_VideoCaptureFactory_getDeviceId(env, camera_id)));
+        base::android::ConvertJavaStringToUTF8(device_name), device_id);

[mcasas, 2014/10/20 11:33:42]

nit: I would use here base::IntToString(camera_id) 
instead of creating a |device_id| explicitly.

[qinmin, 2014/10/20 17:46:23]

Done.

     device_names->push_back(name);
 
     DVLOG(1) << "VideoCaptureDeviceFactoryAndroid::GetDeviceNames: camera "
              << "device_name=" << name.name() << ", unique_id=" << name.id();
   }
 }
 
 void VideoCaptureDeviceFactoryAndroid::GetDeviceSupportedFormats(
     const VideoCaptureDevice::Name& device,
     VideoCaptureFormats* capture_formats) {
@@ skipping 31 matching lines @@
                       format.obj())),
         media::Java_VideoCaptureFactory_getCaptureFormatFramerate(env,
                                                                   format.obj()),
         pixel_format);
     capture_formats->push_back(capture_format);
     DVLOG(1) << device.name() << " " << capture_format.ToString();
   }
 }
 
 }  // namespace media