Chromium Code Reviews Chromium Code Reviews
Issue
667393002:
[XHR] No need to remember line number and URL on send() for inspector (Closed)
Description[XHR] No need to remember line number and URL on send() for inspector
XMLHttpRequest implementation has methods to set line number and URL of
send() method call to pass to
InspectorInstrumentation::didFinishXHRLoading(), but they are not used.
We can just remove this code. See below.
Since WebInspector.ConsoleMessage gets the corresponding request object
in its constructor using the requestId parameter and extracts the line
number and URL of send() method call, we don't need to remember and
pass them from the XMLHttpRequest class as far as we pass the request
identifier given on XMLHttpRequest::didFinishLoading() call to
InspectorInstrumentation::didFinishXHRLoading().
R=sigbjornf,eustas
BUG=none
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184163
Patch Set 1 #
Total comments: 2
Patch Set 2 : Addressed #3 #Patch Set 3 : Rebase #
Messages
Total messages: 8 (2 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
