Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: Source/core/inspector/InspectorConsoleAgent.cpp

Issue 667393002: [XHR] No need to remember line number and URL on send() for inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 if (!m_state->getBoolean(ConsoleAgentState::tracingBasedTimeline)) 174 if (!m_state->getBoolean(ConsoleAgentState::tracingBasedTimeline))
175 m_timelineAgent->consoleTimeline(context, title, scriptState); 175 m_timelineAgent->consoleTimeline(context, title, scriptState);
176 } 176 }
177 177
178 void InspectorConsoleAgent::consoleTimelineEnd(ExecutionContext* context, const String& title, ScriptState* scriptState) 178 void InspectorConsoleAgent::consoleTimelineEnd(ExecutionContext* context, const String& title, ScriptState* scriptState)
179 { 179 {
180 if (!m_state->getBoolean(ConsoleAgentState::tracingBasedTimeline)) 180 if (!m_state->getBoolean(ConsoleAgentState::tracingBasedTimeline))
181 m_timelineAgent->consoleTimelineEnd(context, title, scriptState); 181 m_timelineAgent->consoleTimelineEnd(context, title, scriptState);
182 } 182 }
183 183
184 void InspectorConsoleAgent::didFinishXHRLoading(XMLHttpRequest*, ThreadableLoade rClient*, unsigned long requestIdentifier, ScriptString, const AtomicString& met hod, const String& url, const String& sendURL, unsigned sendLineNumber) 184 void InspectorConsoleAgent::didFinishXHRLoading(XMLHttpRequest*, ThreadableLoade rClient*, unsigned long requestIdentifier, ScriptString, const AtomicString& met hod, const String& url)
185 { 185 {
186 if (m_frontend && m_state->getBoolean(ConsoleAgentState::monitoringXHR)) { 186 if (m_frontend && m_state->getBoolean(ConsoleAgentState::monitoringXHR)) {
187 String message = "XHR finished loading: " + method + " \"" + url + "\"." ; 187 String message = "XHR finished loading: " + method + " \"" + url + "\"." ;
188 RefPtrWillBeRawPtr<ConsoleMessage> consoleMessage = ConsoleMessage::crea te(NetworkMessageSource, DebugMessageLevel, message, sendURL, sendLineNumber); 188 RefPtrWillBeRawPtr<ConsoleMessage> consoleMessage = ConsoleMessage::crea te(NetworkMessageSource, DebugMessageLevel, message);
189 consoleMessage->setRequestIdentifier(requestIdentifier); 189 consoleMessage->setRequestIdentifier(requestIdentifier);
190 messageStorage()->reportMessage(consoleMessage.release()); 190 messageStorage()->reportMessage(consoleMessage.release());
191 } 191 }
192 } 192 }
193 193
194 void InspectorConsoleAgent::setMonitoringXHREnabled(ErrorString*, bool enabled) 194 void InspectorConsoleAgent::setMonitoringXHREnabled(ErrorString*, bool enabled)
195 { 195 {
196 m_state->setBoolean(ConsoleAgentState::monitoringXHR, enabled); 196 m_state->setBoolean(ConsoleAgentState::monitoringXHR, enabled);
197 } 197 }
198 198
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 { 325 {
326 InjectedScript injectedScript = m_injectedScriptManager->injectedScriptForOb jectId(objectId); 326 InjectedScript injectedScript = m_injectedScriptManager->injectedScriptForOb jectId(objectId);
327 if (injectedScript.isEmpty()) { 327 if (injectedScript.isEmpty()) {
328 *errorString = "Inspected frame has gone"; 328 *errorString = "Inspected frame has gone";
329 return; 329 return;
330 } 330 }
331 injectedScript.setLastEvaluationResult(objectId); 331 injectedScript.setLastEvaluationResult(objectId);
332 } 332 }
333 333
334 } // namespace blink 334 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorConsoleAgent.h ('k') | Source/core/inspector/InspectorInstrumentation.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698