Issue 6673025: Merge 77732 - Fix the flakiness with download requests routed by ChromeFrame ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6673025: Merge 77732 - Fix the flakiness with download requests routed by ChromeFrame ... (Closed)

Created:
9 years, 9 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
ananta

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/branches/648/src/

Visibility:
Public.

Description

Merge 77732 - Fix the flakiness with download requests routed by ChromeFrame to the host browser. We issue the NavigateWithBindCtx interface call to issue a navigation such that it reuses the existing bind context. This basically results in a cross apartment deadlock at times when we are in the context of a OnStopBinding call in our bind status callback implementation. The Navigate call is marshaled to a different thread which tries to grab a urlmon critical section which is held in the context of the OnStopBinding call by the current thread. Fix is to use PostMessage to ensure that we unwind the current call chain. BUG=73985 TEST=As described in the bug. Review URL: http://codereview.chromium.org/6677004 TBR=ananta@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78113

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -13 lines)			Patch
M	chrome_frame/chrome_frame_activex_base.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome_frame/urlmon_url_request.cc	View	1 chunk	+7 lines, -10 lines	0 comments	Download
M	chrome_frame/utils.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages