Merge 77732 - Fix the flakiness with download requests routed by ChromeFrame ...

chrome_frame/urlmon_url_request.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_frame/urlmon_url_request.h"
 
 #include <wininet.h>
 #include <urlmon.h>
 
 #include "base/logging.h"
@@ skipping 1041 matching lines @@
   } else {
     NOTREACHED() << "Cannot handle download if we don't have anyone to hand it "
                     "to.";
   }
 }
 
 void UrlmonUrlRequestManager::BindTerminated(IMoniker* moniker,
                                              IBindCtx* bind_ctx,
                                              IStream* post_data,
                                              const char* request_headers) {
-  DownloadInHostParams download_params;
-  download_params.bind_ctx = bind_ctx;
-  download_params.moniker = moniker;
-  download_params.post_data = post_data;
+  DownloadInHostParams* download_params = new DownloadInHostParams;
+  download_params->bind_ctx = bind_ctx;
+  download_params->moniker = moniker;
+  download_params->post_data = post_data;
   if (request_headers) {
-    download_params.request_headers = request_headers;
+    download_params->request_headers = request_headers;
   }
-  // We use SendMessage and not PostMessage to make sure that if the
-  // notification window does not handle the message we won't leak
-  // the moniker.
-  ::SendMessage(notification_window_, WM_DOWNLOAD_IN_HOST,
-        reinterpret_cast<WPARAM>(&download_params), 0);
+  ::PostMessage(notification_window_, WM_DOWNLOAD_IN_HOST,
+        reinterpret_cast<WPARAM>(download_params), 0);
 }
 
 void UrlmonUrlRequestManager::GetCookiesForUrl(const GURL& url, int cookie_id) {
   DWORD cookie_size = 0;
   bool success = true;
   std::string cookie_string;
 
   int32 cookie_action = COOKIEACTION_READ;
   BOOL result = InternetGetCookieA(url.spec().c_str(), NULL, NULL,
                                    &cookie_size);
@@ skipping 162 matching lines @@
       privacy_info_.privacy_records[UTF8ToWide(url)];
 
   privacy_entry.flags |= flags;
   privacy_entry.policy_ref = UTF8ToWide(policy_ref);
 
   if (fire_privacy_event && IsWindow(notification_window_)) {
     PostMessage(notification_window_, WM_FIRE_PRIVACY_CHANGE_NOTIFICATION, 1,
                 0);
   }
 }