chrome/browser/notifications/google_now_notification_stats_collector.h - Issue 667283002: Standardize usage of virtual/override/final in chrome/browser/notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/google_now_notification_stats_collector.h

Issue 667283002: Standardize usage of virtual/override/final in chrome/browser/notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/fullscreen_notification_blocker.h ('k') | chrome/browser/notifications/message_center_notification_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/google_now_notification_stats_collector.h

diff --git a/chrome/browser/notifications/google_now_notification_stats_collector.h b/chrome/browser/notifications/google_now_notification_stats_collector.h

index 3ead04645eeb0c73cf82819fb877dffe08bef2e3..9ce460bb90568a77a14b8b52c724293e72829b13 100644

--- a/chrome/browser/notifications/google_now_notification_stats_collector.h

+++ b/chrome/browser/notifications/google_now_notification_stats_collector.h

@@ -18,14 +18,14 @@ class GoogleNowNotificationStatsCollector

public:

explicit GoogleNowNotificationStatsCollector(

message_center::MessageCenter* message_center);

- virtual ~GoogleNowNotificationStatsCollector();

+ ~GoogleNowNotificationStatsCollector() override;

private:

// MessageCenterObserver

- virtual void OnNotificationDisplayed(

+ void OnNotificationDisplayed(

const std::string& notification_id,

const message_center::DisplaySource source) override;

- virtual void OnCenterVisibilityChanged(

+ void OnCenterVisibilityChanged(

message_center::Visibility visibility) override;

// Counts the number of Google Now Notifications in the message center.