chrome/browser/notifications/fullscreen_notification_blocker.h - Issue 667283002: Standardize usage of virtual/override/final in chrome/browser/notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/fullscreen_notification_blocker.h

Issue 667283002: Standardize usage of virtual/override/final in chrome/browser/notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/extension_welcome_notification_unittest.cc ('k') | chrome/browser/notifications/google_now_notification_stats_collector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/fullscreen_notification_blocker.h

diff --git a/chrome/browser/notifications/fullscreen_notification_blocker.h b/chrome/browser/notifications/fullscreen_notification_blocker.h

index de51ec07f5329cf7bd0b71ef0816d782f665a57e..439e7666d287fa26b522a2ff42d83ba451fd68f9 100644

--- a/chrome/browser/notifications/fullscreen_notification_blocker.h

+++ b/chrome/browser/notifications/fullscreen_notification_blocker.h

@@ -17,20 +17,20 @@ class FullscreenNotificationBlocker

public:

explicit FullscreenNotificationBlocker(

message_center::MessageCenter* message_center);

- virtual ~FullscreenNotificationBlocker();

+ ~FullscreenNotificationBlocker() override;

bool is_fullscreen_mode() const { return is_fullscreen_mode_; }

// message_center::NotificationBlocker overrides:

- virtual void CheckState() override;

- virtual bool ShouldShowNotificationAsPopup(

+ void CheckState() override;

+ bool ShouldShowNotificationAsPopup(

const message_center::NotifierId& notifier_id) const override;

private:

// content::NotificationObserver override.

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

bool is_fullscreen_mode_;