chrome/browser/notifications/extension_welcome_notification_factory.h - Issue 667283002: Standardize usage of virtual/override/final in chrome/browser/notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/extension_welcome_notification_factory.h

Issue 667283002: Standardize usage of virtual/override/final in chrome/browser/notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/extension_welcome_notification.cc ('k') | chrome/browser/notifications/extension_welcome_notification_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/extension_welcome_notification_factory.h

diff --git a/chrome/browser/notifications/extension_welcome_notification_factory.h b/chrome/browser/notifications/extension_welcome_notification_factory.h

index 194e8dc777ea11b22450d88f22efaadbb5ea5f98..e51a9acd4ca645d638505aa0da891d2edf0db500 100644

--- a/chrome/browser/notifications/extension_welcome_notification_factory.h

+++ b/chrome/browser/notifications/extension_welcome_notification_factory.h

@@ -25,12 +25,12 @@ class ExtensionWelcomeNotificationFactory

friend struct DefaultSingletonTraits<ExtensionWelcomeNotificationFactory>;

ExtensionWelcomeNotificationFactory();

- virtual ~ExtensionWelcomeNotificationFactory();

+ ~ExtensionWelcomeNotificationFactory() override;

// BrowserContextKeyedServiceFactory:

- virtual KeyedService* BuildServiceInstanceFor(

+ KeyedService* BuildServiceInstanceFor(

content::BrowserContext* context) const override;

- virtual content::BrowserContext* GetBrowserContextToUse(

+ content::BrowserContext* GetBrowserContextToUse(

content::BrowserContext* context) const override;

};