Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1736)

Unified Diff: chrome/browser/notifications/extension_welcome_notification.cc

Issue 667283002: Standardize usage of virtual/override/final in chrome/browser/notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/extension_welcome_notification.cc
diff --git a/chrome/browser/notifications/extension_welcome_notification.cc b/chrome/browser/notifications/extension_welcome_notification.cc
index 1963c3b0fb925deb2b46789e8bc8aca83e9499ff..c061dd8a877ccdc068d7a9a5524adf925b0ca540 100644
--- a/chrome/browser/notifications/extension_welcome_notification.cc
+++ b/chrome/browser/notifications/extension_welcome_notification.cc
@@ -47,10 +47,10 @@ class NotificationCallbacks
}
// Overridden from NotificationDelegate:
- virtual void Display() override {}
- virtual void Error() override {}
+ void Display() override {}
+ void Error() override {}
- virtual void Close(bool by_user) override {
+ void Close(bool by_user) override {
if (by_user) {
// Setting the preference here may cause the notification erasing
// to reenter. Posting a task avoids this issue.
@@ -60,8 +60,8 @@ class NotificationCallbacks
}
}
- virtual void Click() override {}
- virtual void ButtonClick(int index) override {
+ void Click() override {}
+ void ButtonClick(int index) override {
if (index == 0) {
OpenNotificationLearnMoreTab();
} else if (index == 1) {
@@ -98,7 +98,7 @@ class NotificationCallbacks
notifier, false);
}
- virtual ~NotificationCallbacks() {}
+ ~NotificationCallbacks() override {}
Profile* const profile_;
@@ -116,17 +116,14 @@ class DefaultDelegate : public ExtensionWelcomeNotification::Delegate {
public:
DefaultDelegate() {}
- virtual message_center::MessageCenter* GetMessageCenter() override {
+ message_center::MessageCenter* GetMessageCenter() override {
return g_browser_process->message_center();
}
- virtual base::Time GetCurrentTime() override {
- return base::Time::Now();
- }
+ base::Time GetCurrentTime() override { return base::Time::Now(); }
- virtual void PostTask(
- const tracked_objects::Location& from_here,
- const base::Closure& task) override {
+ void PostTask(const tracked_objects::Location& from_here,
+ const base::Closure& task) override {
base::MessageLoop::current()->PostTask(from_here, task);
}

Powered by Google App Engine
This is Rietveld 408576698