Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 667273002: Fix context menu positioning in MimeHandlerViewGuest. (Closed)

Created:
6 years, 2 months ago by lazyboy
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix context menu positioning in MimeHandlerViewGuest. BUG=422641 Test=Load chrome with the following flags: --out-of-process-pdf, --enable-mime-handler-view Load a PDF in a <webview>, e.g. use the webview-sample/browser app: https://chrome.google.com/webstore/detail/edggnmnajhcbhlnpjnogkjpghaikidaa and navigate to a PDF. Right clicking the PDF should bring context menu to correct position relative to the cursor. Committed: https://crrev.com/b4adc139a023f5e77cabc715f46e3c4e0e432105 Cr-Commit-Position: refs/heads/master@{#300639}

Patch Set 1 #

Patch Set 2 : fix gn build #

Patch Set 3 : rebase @tott, fix merge conflict #

Messages

Total messages: 15 (6 generated)
lazyboy
6 years, 2 months ago (2014-10-21 20:39:50 UTC) #2
Fady Samuel
lgtm
6 years, 2 months ago (2014-10-21 21:39:42 UTC) #3
lazyboy
+Ken for *.gyp and *.gn changes.
6 years, 2 months ago (2014-10-22 02:25:38 UTC) #5
Ken Rockot(use gerrit already)
lgtm
6 years, 2 months ago (2014-10-22 02:28:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667273002/20001
6 years, 2 months ago (2014-10-22 03:00:29 UTC) #8
commit-bot: I haz the power
Failed to apply patch for chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc: While running git apply --index -3 -p1; error: patch ...
6 years, 2 months ago (2014-10-22 04:15:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667273002/40001
6 years, 2 months ago (2014-10-22 05:40:12 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-22 06:29:34 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-10-22 06:30:38 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b4adc139a023f5e77cabc715f46e3c4e0e432105
Cr-Commit-Position: refs/heads/master@{#300639}

Powered by Google App Engine
This is Rietveld 408576698