extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.h - Issue 667273002: Fix context menu positioning in MimeHandlerViewGuest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.h

Issue 667273002: Fix context menu positioning in MimeHandlerViewGuest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase @tott, fix merge conflict Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc ('k') | extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.h

diff --git a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.h b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.h

index 53e8cc7154548536c8d1a40d17e356a8fc53b0d6..b9a6fe3533adf9d3719e736e029e36693c7d304c 100644

--- a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.h

+++ b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.h

@@ -9,6 +9,7 @@

namespace content {

class WebContents;

+struct ContextMenuParams;

} // namespace content

namespace extensions {

@@ -24,6 +25,10 @@ class MimeHandlerViewGuestDelegate {

// Attaches helpers upon initializing the WebContents.

virtual void AttachHelpers() {}

+ // Handles context menu, or returns false if unhandled.

+ virtual bool HandleContextMenu(content::WebContents* web_contents,

+ const content::ContextMenuParams& params);

// Request to change the zoom level of the top level page containing

// this view.

virtual void ChangeZoom(bool zoom_in) {}