Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 667253002: Speed up creation of Objects whose prototype has dictionary elements (Closed)

Created:
6 years, 2 months ago by adamk
Modified:
6 years, 2 months ago
CC:
v8-dev, danno, Michael Starzinger
Project:
v8
Visibility:
Public.

Description

Speed up creation of Objects whose prototype has dictionary elements This speeds up both the case from the bug (using Object.create) but also takes care ofthe "{ __proto__: obj }" syntax, which was previously (and erroneously) being treated the same as setting the prototype dynamically from script using the __proto__ setter or Object.setPrototypeOf. BUG=chromium:422754 LOG=y R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/fast-prototype.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
adamk
6 years, 2 months ago (2014-10-21 19:31:37 UTC) #2
mvstanton
LGTM.
6 years, 2 months ago (2014-10-22 11:13:51 UTC) #4
adamk
6 years, 2 months ago (2014-10-22 18:16:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24814 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698