src/objects.cc - Issue 667253002: Speed up creation of Objects whose prototype has dictionary elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 667253002: Speed up creation of Objects whose prototype has dictionary elements (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 47a61f627b817ca7d533aea305cfde7b90e4d110..5d85b13614ca6c2c64592cf769e2b7a88d5a5936 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -11796,7 +11796,7 @@ MaybeHandle<Object> JSObject::SetPrototype(Handle<JSObject> object,

DCHECK(new_map->prototype() == *value);

JSObject::MigrateToMap(real_receiver, new_map);

- if (!dictionary_elements_in_chain &&

+ if (from_javascript && !dictionary_elements_in_chain &&

new_map->DictionaryElementsInPrototypeChainOnly()) {

// If the prototype chain didn't previously have element callbacks, then

// KeyedStoreICs need to be cleared to ensure any that involve this

« no previous file with comments | « src/mips64/full-codegen-mips64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »