Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 667223002: Mojo: More virtual/override style fixes in mojo/. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: More virtual/override style fixes in mojo/. This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. (Run on Linux, for the mojo target.) R=sky@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/353493d702c3c9b4f7cecccfbc4188012bf813ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -341 lines) Patch
M mojo/aura/screen_mojo.h View 1 chunk +13 lines, -17 lines 0 comments Download
M mojo/aura/surface_binding.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/aura/surface_context_factory.h View 1 chunk +11 lines, -13 lines 0 comments Download
M mojo/aura/window_tree_host_mojo.h View 2 chunks +18 lines, -18 lines 0 comments Download
M mojo/public/python/src/python_system_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/native_viewport/platform_viewport_x11.cc View 3 chunks +18 lines, -38 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_test_suite.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/view_manager/connection_manager.h View 2 chunks +16 lines, -16 lines 0 comments Download
M mojo/services/view_manager/default_access_policy.h View 1 chunk +15 lines, -16 lines 0 comments Download
M mojo/services/view_manager/display_manager.h View 2 chunks +5 lines, -6 lines 0 comments Download
M mojo/services/view_manager/main.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M mojo/services/view_manager/view_manager_init_service_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.h View 3 chunks +33 lines, -36 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 6 chunks +39 lines, -43 lines 0 comments Download
M mojo/services/view_manager/window_manager_access_policy.h View 1 chunk +15 lines, -16 lines 0 comments Download
M mojo/services/view_manager/window_manager_client_impl.h View 1 chunk +3 lines, -4 lines 0 comments Download
M mojo/services/window_manager/main.cc View 1 chunk +10 lines, -12 lines 0 comments Download
M mojo/services/window_manager/window_manager_api_unittest.cc View 4 chunks +20 lines, -22 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.h View 2 chunks +18 lines, -20 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.cc View 1 chunk +20 lines, -18 lines 0 comments Download
M mojo/services/window_manager/window_manager_service2_impl.h View 2 chunks +5 lines, -8 lines 0 comments Download
M mojo/services/window_manager/window_manager_service_impl.h View 1 chunk +5 lines, -6 lines 0 comments Download
M mojo/services/window_manager/window_manager_unittests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/external_application_listener_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/shell/external_application_registrar_connection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/incoming_connection_listener_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
6 years, 2 months ago (2014-10-21 18:20:33 UTC) #1
sky
Rubber stamp LGTM
6 years, 2 months ago (2014-10-21 18:21:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667223002/1
6 years, 2 months ago (2014-10-21 18:30:31 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/353493d702c3c9b4f7cecccfbc4188012bf813ef Cr-Commit-Position: refs/heads/master@{#300530}
6 years, 2 months ago (2014-10-21 18:59:31 UTC) #5
viettrungluu
6 years, 2 months ago (2014-10-21 18:59:39 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
353493d702c3c9b4f7cecccfbc4188012bf813ef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698